-
Notifications
You must be signed in to change notification settings - Fork 40
Card Button in SwiftUI #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card Button in SwiftUI #1981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component looks great! Could you record a video of how it works with a screen reader?
When it's off, when it's tapped, when it's on?
} | ||
|
||
// MARK: - previews | ||
#Preview { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our CI runs on Xcode 14, so I think we should use the 'old preview style' for it to pass
Snapshots were updated. Please verify the changes match the expected layout.
|
@gert-janvercauteren The video of how it works with a screen reader👇 Screen.Recording.2024-06-06.at.14.34.27.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it ❤️
Great to also see the accessibility guidance on the README!
Card Button in SwiftUI
Remember to include the following changes:
README.md
Backpack.h
header fileIf you are curious about how we review, please read through the code review guidelines