Add Dockerfile and packages #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigJoe
reviewed
Apr 8, 2025
Dockerfile
Outdated
| mv microsoft.gpg /etc/apt/trusted.gpg.d/microsoft.gpg && \ | ||
| echo "deb [arch=amd64] https://packages.microsoft.com/debian/$(lsb_release -rs | cut -d'.' -f 1)/prod $(lsb_release -cs) main" > /etc/apt/sources.list.d/dotnetdev.list && \ | ||
| apt-get update && \ | ||
| apt-get install -y azure-functions-core-tools-4 |
There was a problem hiding this comment.
I suggest adding && rm -rf /var/lib/apt/lists/* to the end of that RUN
sigJoe
reviewed
Apr 8, 2025
Dockerfile
Outdated
| FROM mcr.microsoft.com/azure-functions/python:4-python3.11 | ||
| LABEL maintainer="[email protected]" | ||
|
|
||
| RUN apt update \ |
There was a problem hiding this comment.
maybe combine these apt things with the apt-get below?
sigJoe
reviewed
Apr 8, 2025
| @@ -0,0 +1,19 @@ | |||
| FROM mcr.microsoft.com/azure-functions/python:4-python3.11 | |||
There was a problem hiding this comment.
It's the base container that is actually used in azure to run functions is my understanding
There was a problem hiding this comment.
Still needs to add clis which is odd but I followed their example
sigJoe
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker image for azure function tools