Skip to content

Add Support for XML #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025
Merged

Add Support for XML #5256

merged 4 commits into from
Apr 10, 2025

Conversation

nasbench
Copy link
Member

@nasbench nasbench commented Apr 7, 2025

Summary of the Pull Request

Add filters for XML raw IP log.

Changelog

fix: Potential CVE-2023-23397 Exploitation Attempt - SMB - Add filters for IP format when ingesting XML raw event

Example Log Event

N/A

Fixed Issues

N/A

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

@crayy8
Copy link

crayy8 commented Apr 7, 2025

@nasbench I've provided sample xml output here

@nasbench
Copy link
Member Author

nasbench commented Apr 8, 2025

For reviewers, please give this a read to understand the filters

https://github.com/nasbench/Misc-Research/blob/main/ETW/Microsoft-Windows-SMBClient.md

@nasbench nasbench requested a review from frack113 April 8, 2025 10:30
@nasbench nasbench added the 2nd Review Needed PR need a second approval label Apr 8, 2025
@nasbench nasbench merged commit 3946f67 into master Apr 10, 2025
23 checks passed
@nasbench nasbench deleted the add-support-xml branch April 10, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants