Migrate Ruby LSP add-on to RBS comments #2304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
the
refactor
Graphite App
Morriar
reviewed
Jun 2, 2025
vinistock
force-pushed
the
06-02-migrate_ruby_lsp_add-on_to_rbs_comments
branch
from
a6ec5f5 to
aedfc5d
Compare
Morriar
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate all of the Tapioca add-on to RBS comments since we're going to remove the Ruby LSP's dependency on the
sorbet-runtimegem. This will make sure that Tapioca is ready for the breaking change ahead of time.Implementation
Just migrated everything to the RBS comment syntax. I also made some minor style modifications.
Tests
Current tests should cover it.