Remove YJIT setting #1427
Merged
Remove YJIT setting #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
approved these changes
Feb 28, 2024
vinistock
added
enhancement
paracycle
reviewed
Feb 28, 2024
| minor === 2; | ||
|
|
||
| if (this.supportsYjit && useYjit) { | ||
| if (this.supportsYjit && major === 3 && minor === 2) { |
There was a problem hiding this comment.
This is strange. Am I reading this line correctly, that it only enables YJIT on Ruby 3.2 and not on any other version, like 3.3?
There was a problem hiding this comment.
That's correct. On 3.3 or higher, we only enable YJIT once the LSP finished booting here.
There was a problem hiding this comment.
Oh, I just saw the comment above this line. In that case, can't we just move the exact version check to the definition of supportsYjit and make it:
this.supportsYjit = this.yjitEnabled && major == 3 && minor == 2;?
There was a problem hiding this comment.
And maybe rename that field to reflect the new meaning as well.
There was a problem hiding this comment.
Yeah, that's a fair point. I'll follow up with another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Starting to migrate Shopify/vscode-ruby-lsp#923 into this repo by parts.
We added the possibility to turn off YJIT (even when Ruby was compiled with support for it) just in case there was a major issue with YJIT that prevented people from using the LSP. It's been a long time and no one has ever reported any YJIT related issues that weren't fixed before Ruby releases, so keeping this setting doesn't add much value.
Implementation
Removed the setting, the related status item and command.