Properly populate and invalidate the local cache during CAS operations #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
requested review from
rafaelfranca,
shioyama,
dylanahsmith and
dougedey-shopify
dougedey-shopify
approved these changes
Aug 18, 2021
casperisfine
force-pushed
the
cas-local-cache-support
branch
from
ac5a7b6 to
20600d2
Compare
casperisfine
force-pushed
the
cas-local-cache-support
branch
from
20600d2 to
7d0bafe
Compare
dylanahsmith
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemcachedStoreprepends theStrategy::LocalCachemodule, however it doesn't consider it at all incasandcas_multi.Because of this, these two methods can let the local cache in an inconsistent state (see the added tests).