Skip to content

Add Tapioca compiler #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2025
Merged

Add Tapioca compiler #533

merged 3 commits into from
Jan 21, 2025

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jan 15, 2025

No description provided.

@st0012 st0012 force-pushed the add-tapioca-compiler branch 2 times, most recently from c189641 to a80d9ea Compare January 15, 2025 19:39
Mangara
Mangara reviewed Jan 15, 2025
View reviewed changes
Mangara
Mangara reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Mangara Mangara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot this initially - can we generate a signature for perform as well? It'll be the same type signature as perform_now, but an instance method, instead of a class method.

paracycle
paracycle reviewed Jan 15, 2025
View reviewed changes
Mangara
Mangara reviewed Jan 15, 2025
View reviewed changes
@st0012 st0012 force-pushed the add-tapioca-compiler branch 3 times, most recently from 3424803 to c76569d Compare January 15, 2025 21:36
paracycle
paracycle reviewed Jan 15, 2025
View reviewed changes
@st0012 st0012 force-pushed the add-tapioca-compiler branch 2 times, most recently from fceeb76 to 02fc468 Compare January 16, 2025 21:28
Mangara
Mangara approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Mangara Mangara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI failures are addressed.

@st0012 st0012 force-pushed the add-tapioca-compiler branch 3 times, most recently from a1a68ef to df26d0d Compare January 20, 2025 17:29
@st0012 st0012 requested review from paracycle and Mangara January 20, 2025 17:50
@st0012 st0012 marked this pull request as ready for review January 20, 2025 17:50
@st0012 st0012 force-pushed the add-tapioca-compiler branch from 78130d0 to bb95472 Compare January 20, 2025 18:32
st0012 added 3 commits January 20, 2025 19:51
@st0012
Add Tapioca compiler for JobIteration
4fdc8bc 
It takes the job's `build_enumerator` method and generates the signatures
for the job's corresponding `perform_later` and `perform_now` methods.
@st0012
Only run the new compiler tests when Tapioca is greater than 0.13.0
732a1cf
@st0012
Simplify implementation
79a7ba3
@st0012 st0012 force-pushed the add-tapioca-compiler branch from 4ae6408 to 79a7ba3 Compare January 20, 2025 19:51
@st0012 st0012 added the enhancement New feature or request label Jan 20, 2025
@st0012 st0012 merged commit 5f44ee6 into main Jan 21, 2025
49 checks passed
@st0012 st0012 deleted the add-tapioca-compiler branch January 21, 2025 19:32
@emilylin0 emilylin0 mentioned this pull request Mar 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

@Mangara Mangara Awaiting requested review from Mangara

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st0012 @paracycle @Mangara