Enable CSV Batching #509
Merged
Enable CSV Batching #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harmanT23
force-pushed
the
htatla-add-csv-batching
branch
from
f89ccb9 to
0a16f41
Compare
Mangara
approved these changes
Oct 3, 2024
harmanT23
force-pushed
the
htatla-add-csv-batching
branch
from
0a16f41 to
18a8b11
Compare
harmanT23
force-pushed
the
htatla-add-csv-batching
branch
from
18a8b11 to
3604054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that although CSV batching was implemented in CsvEnumerator, it was not implemented yet in
EnumeratorBuilder.I've gone ahead and added in
build_csv_enumerator_on_batcheswith a defaultbatch_sizeof100identical to the default used for active record batching along with an alias ofcsv_on_batches.