update error handle, ensure no cancel on failure, clear cache on preload #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiftio
commented
Jan 25, 2024
| @@ -34,7 +34,7 @@ import com.shopify.checkoutsheetkit.pixelevents.PixelEvent | |||
| internal class CheckoutWebViewEventProcessor( | |||
| private val eventProcessor: CheckoutEventProcessor, | |||
| private val toggleHeader: (Boolean) -> Unit = {}, | |||
| private val closeCheckoutDialog: () -> Unit = {}, | |||
| private val closeCheckoutDialogWithError: (CheckoutException) -> Unit = { CheckoutWebView.clearCache() }, | |||
There was a problem hiding this comment.
This is a default function, that is called if onCheckoutViewFailedWithError() is invoked before the view is presented in the dialog
kiftio
commented
Jan 25, 2024
| @@ -28,7 +28,7 @@ android { | |||
| applicationId "com.shopify.checkout_sdk_mobile_buy_integration_sample" | |||
| minSdk 23 | |||
| targetSdk 34 | |||
| versionCode 17 | |||
| versionCode 20 | |||
There was a problem hiding this comment.
Unrelated - just updating to the next Google Play version
markmur
reviewed
Jan 25, 2024
lib/src/main/java/com/shopify/checkoutsheetkit/CheckoutDialog.kt
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/shopify/checkoutsheetkit/CheckoutDialog.kt
Outdated
Show resolved
Hide resolved
markmur
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Adding
clearCache()withinhandleErrorrecently was incorrect (unreleased so far). The cache was already being cleared in the case where checkout was already presented.Instead we just needed to clear the cache for preloads. This is now being done in
CheckoutWebViewEventProcessor.Additionally, as errors were calling through to cancel, we were firing both
onCheckoutCancelandonCheckoutErrorcallbacks. This has been updated to ensure just one is called.Cancel
err.mp4
Error
cancel.mp4
Before you deploy