-
Notifications
You must be signed in to change notification settings - Fork 11
Add debug logging #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add debug logging #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8ae6b7
to
0480e67
Compare
…ebug values in the future
@kiftio want to align this with the swift implementation? /// Levels: all, debug, error, none
/// Default: .error - which will emit "error" and "fault" logs
public var logLevel: LogLevel = .error |
I've updated it to something similar |
f5869e0
to
9832d1d
Compare
markmur
approved these changes
May 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
kieran-osgood-shopify
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Allowing emission of debug logs via
I've opted to enabling debug logs only via explicit configuration to prevent altering logging for any existing clients who don't require it (via defaulting to
LogLevel.WARN
).Video of some logs being emitted:
debug-logs.mp4
How to test
Then repeat, with
LogLevel.WARN
,LogLevel.ERROR
, and omittingit.logLevel
to check the default, and ensure the logs no longer appear.Before you merge
Important
Checklist for releasing a new version
build.gradle
fileTip
See the Contributing documentation for instructions on how to publish a new version of the library.