Open deep links externally #139
Conversation
| <queries> | ||
| <!-- for supporting deep links to the maps app --> | ||
| <intent> | ||
| <action android:name="android.intent.action.VIEW" /> | ||
| <data android:scheme="geo" /> | ||
| </intent> | ||
|
|
||
| <!-- for supporting deep links to the messaging app --> | ||
| <intent> | ||
| <action android:name="android.intent.action.SENDTO" /> | ||
| <data android:scheme="sms" /> | ||
| </intent> | ||
| </queries> |
There was a problem hiding this comment.
What will happen if a developer doesn't include this in their manifest?
There was a problem hiding this comment.
It looks like behaviour depends on API version.
For < 11:
It sounds a bit like a free-for-all, let me do some testing...
For >= 11:
When querying for info about other apps, the system filters info. So the code wouldn't detect that there's anything able to handle the scheme, and we'd log a warning instead of launching the intent.
And the <queries> element declares which apps you want to interact with and makes them visible. Inside queries you could also make it a specific package if you want a specific app instead of any app that can handle the intent as shown above. So, it should give quite good flexibility for clients to decide what they want to launch.
There was a problem hiding this comment.
It might be worth updating the warning to link to the readme, or to explain that the intent is probably missing from the manifest
There was a problem hiding this comment.
I tested pre 11, yeah it opens up e.g. the maps, and messaging app even if the queries element is commented/missing from the manifest.
👍 I added a little more info to the README
kiftio
force-pushed
the
dk/open-deeplinks-externally
branch
from
1a1dd96 to
05fb7f1
Compare
What changes are you making?
Open deep links externally, similar to ios here - Shopify/checkout-sheet-kit-swift#227
onCheckoutLinkClicked()queriesin its manifest to determine which links/schemes should open.How to test
Tested with a couple of links
deeplinks.mp4
Before you merge
Important
Checklist for releasing a new version
build.gradlefileTip
See the Contributing documentation for instructions on how to publish a new version of the library.