Skip to content

Update FileChooserResultContract.kt #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

WalidAhmed90
Copy link
Contributor

This pull request resolves issues with handling camera image results across all devices, particularly targeting inconsistencies found on certain devices like Samsung and Xiaomi during checkout.

Note: I have made changes in the sample app not in the lib so thats why, I haven't updated the ReadMe and ChangeLog files

What changes are you making?

  • Improved handling of camera image results for all devices by ensuring the correct URI is received, addressing device-specific issues.
  • Adjusted camera and file picker integration for consistent behaviour across different Android manufacturers.

How to test

  • Launch the checkout flow that includes the camera and file picker feature.
  • Test capturing an image using the camera on a variety of devices (e.g., Samsung, Xiaomi).
  • Verify that the captured image is returned correctly across all tested devices.
  • Test the fallback to the file picker to ensure proper handling of images from the gallery.

Before you merge

Important


Checklist for releasing a new version

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

handle issues of camera image result for all devices
Update ChangeLog and ReadMe Files
Discard changes from Readme and Changelog files
@WalidAhmed90 WalidAhmed90 requested a review from a team as a code owner September 27, 2024 15:20
@WalidAhmed90
Copy link
Contributor Author

I have signed the CLA!

@kiftio
Copy link
Contributor

kiftio commented Oct 1, 2024

Thanks for this 🙏

@WalidAhmed90
Copy link
Contributor Author

You welcome 👍

@kiftio kiftio merged commit 28c2f6d into Shopify:main Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants