Implement onShowFileChooser, calling delegate #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiftio
force-pushed
the
dk/onshowfilechooser
branch
from
dc2c647 to
a78adad
Compare
kiftio
commented
Sep 6, 2024
| @@ -60,6 +62,7 @@ internal abstract class BaseWebView(context: Context, attributeSet: AttributeSet | |||
| settings.apply { | |||
| javaScriptEnabled = true | |||
| domStorageEnabled = true | |||
| allowContentAccess = true | |||
There was a problem hiding this comment.
The default is enabled, this just makes it explicit.
kiftio
force-pushed
the
dk/onshowfilechooser
branch
from
a78adad to
3b7253f
Compare
kiftio
commented
Sep 6, 2024
| permissionRequest.deny() | ||
| } | ||
| } | ||
| override fun onShowFileChooser( |
There was a problem hiding this comment.
I'm replacing the onPermissionRequest() implementation, as it's not needed for the flow we have a use-case for, which doesn't launch a camera feed directly, but instead needs to show a file chooser.
kiftio
force-pushed
the
dk/onshowfilechooser
branch
from
b28923b to
8961e01
Compare
markmur
approved these changes
Sep 6, 2024
...ava/com/shopify/checkout_sdk_mobile_buy_integration_sample/common/MobileBuyEventProcessor.kt
Outdated
Show resolved
Hide resolved
kiftio
force-pushed
the
dk/onshowfilechooser
branch
from
be93c26 to
0408312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Implement
onShowFileChooser(), calling delegate, for merchants with 3p apps installed which require that functionality.How to test
Run the sample app against a store that uses id.me, try and submit a photo / file.
Before you merge
Important
Checklist for releasing a new version
build.gradlefileTip
See the Contributing documentation for instructions on how to publish a new version of the library.