Update sample to call preload at a more appropriate time #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
The README states that
preload()
should be used responsibly as it results in background network requests and additional CPU/memory utilization for the client. And that it should only be used when there is a high likelihood that the buyer will soon request to checkout.But the sample apps call it on each cart mutation / add to cart, which is more frequently than it needs to be called.
This updates the sample to follow the README advice, and only call
preload()
when a customer lands on the cart page.It also updates an incorrect line r.e. min JDK version in the README
How to test
Click around in the sample
Before you merge
Important
Checklist for releasing a new version
build.gradle
fileTip
See the Contributing documentation for instructions on how to publish a new version of the library.