Skip to content

set preloading tag on instrumentation event #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

kiftio
Copy link
Contributor

@kiftio kiftio commented Aug 2, 2024

What changes are you making?

Update instrumentation to pass through a preloading tag. Basing the value on whether the last loadCheckout has isPreload = true

How to test

Open checkout, preload, check instrumentation payload.
Do the same without preloading

Before you merge

Important


Checklist for releasing a new version

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

@kiftio kiftio marked this pull request as ready for review August 2, 2024 13:18
@kiftio kiftio requested a review from a team as a code owner August 2, 2024 13:18
@kiftio kiftio merged commit 63552c0 into main Aug 2, 2024
4 checks passed
@kiftio kiftio deleted the dk/instrumentation-tag branch August 2, 2024 13:40
@markmur markmur mentioned this pull request Aug 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants