Add generated label to autogenerated metrics #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhittaker
approved these changes
May 6, 2024
rgrandl
force-pushed
the
add_generated_labels_to_metrics
branch
from
d9c5e1d to
498f489
Compare
Service Weaver users complain that we're exporting too many metrics, hence the cloud bill is high. This is mainly because we export a bunch of metrics that are either autogenerated or created within our system components. This PR adds a new label to each of these metrics, s.t. the deployer can decide to filter them out, before exporting the metrics for consumption.
rgrandl
force-pushed
the
add_generated_labels_to_metrics
branch
from
498f489 to
7fe678e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service Weaver users complain that we're exporting too many metrics, hence the cloud bill is high. This is mainly because we export a bunch of metrics that are either autogenerated or created within our system components.
This PR adds a new label to each of these metrics, s.t. the deployer can decide to filter them out, before exporting the metrics for consumption.