Fix: Make Flags.from_dict generic to support all subclasses

[Mirza-Samad-Ahmed-Baig]

This PR addresses a bug in the Flags.from_dict class method where it was hardcoded to return an ObsFlags instance, preventing it from correctly instantiating other subclasses like ActionFlags. The method has been updated to be fully generic. It now uses the class it is called on (cls) for instantiation and filters the input dictionary to only include keys that correspond to the class's fields. This ensures that any subclass of Flags can be correctly created from a dictionary, making the implementation more robust and less error-prone.

Description by Korbit AI

What change is being made?

Make the Flags.from_dict method generic to support all subclasses by modifying it to filter dictionary keys based on the subclass's fields and use the class itself instead of a hardcoded subclass for instantiation.

Why are these changes being made?

The existing implementation of Flags.from_dict was not generic, as it specifically returned an ObsFlags instance, limiting support to that subclass only. By making it generic and utilizing subclass fields dynamically, we ensure compatibility with any subclass, improving code reusability and flexibility.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[korbit-ai]

I've completed my review and didn't find any issues... but I did find this frog.

           .--._.--.
          ( O     O )
          /   . .   \
         .`._______.'.
        /(           )\
      _/  \  \   /  /  \_
   .~   `  \  \ /  /  '   ~.
  {    -.   \  V  /   .-    }
_ _`.    \  |  |  |  /    .'_ _
>_       _} |  |  | {_       _<
 /. - ~ ,_-'  .^.  `-_, ~ - .\
         '-'|/   \|`-`

Files scanned

​

File Path	Reviewed
src/agentlab/agents/dynamic_prompting.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X