Issue #147: combine duplicate boxes at the generational level #163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 79.35% 79.34% -0.01%
==========================================
Files 437 437
Lines 58535 58578 +43
Branches 5060 5071 +11
==========================================
+ Hits 46448 46474 +26
- Misses 10851 10866 +15
- Partials 1236 1238 +2
|
| // Check for, and correct, collisions of boxes in this person's | ||
| // generational row. | ||
| int shiftAmount = 0; | ||
| for (int m = 0; m <= fPersons.Count; m++) |
There was a problem hiding this comment.
This is not a mistake by accident?
m <= fPersons.Count
There was a problem hiding this comment.
Yup, it is. Good eye! [There is a loop short-circuit which appears to have prevented it from being an issue in during my testing.]
|
I am sorry :( but... |
|
I'll try to think about how to rebuild the algorithm one of these days. Maybe something will turn out ... |
|
Oh wow! This is definitely much harder than I figured ...
If I can make some time, I'll poke at this new test. In the meantime, it'd
be better to ignore my attempts to fix this. I need to establish a set of
test trees to exercise more variations on the problem.
Sorry for wasting your time ...
Kevin
…On Wed, Nov 29, 2017 at 3:36 PM, Sergey Zhdanovskih < ***@***.***> wrote:
I am sorry :( but...
see the attached file, with descendants from "Sidorov Dmitriy Andreevich"
FullFamilyTreeTests.zip
<https://github.com/Serg-Norseman/GEDKeeper/files/1515448/FullFamilyTreeTests.zip>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJWvP8EM-T3K8Ar8XVJ58A_W6nX_8ORgks5s7cBagaJpZM4QvNsT>
.
|
|
Kevin, it's okay! I am always glad to consider any additions to this project and I am happy with any participation :) I still can not get and think about possible ways to implement the "Full Tree". Work takes up all resources. Perhaps in a week or two there will be additional free time. There are a couple of ideas on how to extend the mapping of branches under the current engine. However, these ideas do not yet relate to how to combine duplicate information. |
Limitation: 'duplicate' boxes can only be combined at the same generational level. 'Duplicates' across generational rows are not combined with this commit.
Limitation: in the specific case shown in issue #147, the "combined" boxes are placed a little "off center". The resulting appearance is not as "nice" as it could be.