Skip to content

Fix long filenames missing . in extension #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

bunny-foofoo
Copy link

Fix for #753

Long file names which end with . were having their path broken during shortening.
e.g.; would be saved as ../../shortened_filenamemp4 instead of ../../shortened_filename.mp4

Fixed the issue and added test coverage for this case.

@OMEGARAZER
Copy link
Contributor

This commit fixes the broken test afd2f88

@Serene-Arc
Copy link
Owner

You a maintainer now @OMEGARAZER ?

@OMEGARAZER
Copy link
Contributor

OMEGARAZER commented Feb 3, 2023

If you mean the approve, it was twofold.

  1. I saw the button and wanted to see if it worked or gave me an error and

  2. If no error, to say that I tried out the changes in this PR and they all worked and passed.

But as far as I'm aware I'm not, no.

@Serene-Arc
Copy link
Owner

All good, just need to know how the permissions distribution. If all the tests passed, then I can merge it

@Serene-Arc Serene-Arc merged commit 7676ff0 into Serene-Arc:development Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants