Skip to content

Unclear descriptions of options #771

Closed
@thomas694

Description

@thomas694

Description

In my opinion the descriptions for --no-dupes and --search-existing could be improved. They are describing something that actually isn't done.

--no-dupes: - This flag will not redownload files if they were already downloaded in the current run

Should be:
This flag will skip the file when a duplicate is downloaded in the current run
Reason:
At this point the file has already been downloaded again and it's only decided whether to skip saving or create a hard link.

--search-existing: - The hashes are used to remove duplicates if --no-dupes is supplied or make hard links if --make-hard-links is supplied

Should be:
The hashes are used to skip duplicates if --no-dupes is supplied or make hard links if --make-hard-links is supplied
Reason:
The meaning of "remove" only gets clear together with the explanation for --no-dupes. Duplicates aren't removed (afterwards), it's only prevented to save a duplicate under a new name.

Is it ok to provide a PR for that?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions