Skip to content

Update Selenium Grid 4.30.0 #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Update Selenium Grid 4.30.0 #2728

merged 1 commit into from
Mar 23, 2025

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Mar 23, 2025

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Tests


Description

  • Updated Selenium Grid version to 4.30.0 in the Makefile.

  • Adjusted browser and Selenium version configurations in test matrices.

  • Updated FFMPEG version to 7.1.1 in the Makefile.


Changes walkthrough 📝

Relevant files
Enhancement
Makefile
Update Selenium Grid and FFMPEG versions                                 

Makefile

  • Updated Selenium Grid version to 4.30.0.
  • Updated FFMPEG version to 7.1.1.
  • Adjusted nightly version to 4.31.0-SNAPSHOT.
  • +8/-8     
    Tests
    browser-matrix.yml
    Adjust browser versions in test matrix                                     

    tests/build-backward-compatible/browser-matrix.yml

  • Updated Chrome version to 134.0.6998.165-1.
  • Updated Edge version to 134.0.3124.83-1.
  • +2/-2     
    selenium-matrix.yml
    Add Selenium Grid 4.30.0 to test matrix                                   

    tests/build-backward-compatible/selenium-matrix.yml

  • Added Selenium Grid version 4.30.0 configuration.
  • Included browser compatibility for version 4.30.0.
  • +6/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Signed-off-by: Viet Nguyen Duc <[email protected]>
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Browser Versions

    The browser compatibility list for Selenium 4.30.0 is empty. Browser versions should be specified to ensure proper testing compatibility.

      browser:
    4.29.0:

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Missing browser compatibility values

    The browser key is missing its values. This will cause configuration errors when
    the system tries to determine which browser versions are compatible with
    Selenium 4.30.0.

    tests/build-backward-compatible/selenium-matrix.yml [14-19]

     +    4.30.0:
     +      BASE_RELEASE: selenium-4.30.0
     +      BASE_VERSION: 4.30.0
     +      VERSION: 4.30.0
     +      BINDING_VERSION: 4.30.0
     +      browser:
    ++        - 134
    ++        - 133
    ++        - 132

    [To ensure code accuracy, apply this suggestion manually]

    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly identifies a critical issue where the browser compatibility list is completely missing for the newly added Selenium 4.30.0 configuration. Without these values, the system would likely fail when trying to determine compatible browser versions.

    High
    • More

    Copy link

    qodo-merge-pro bot commented Mar 23, 2025

    CI Feedback 🧐

    (Feedback updated until commit 268f4af)

    A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

    Action: Rerun workflow when failure

    Failed stage: Authenticate GitHub CLI for PR [❌]

    Failure summary:

    The action failed because the GitHub token provided to the workflow lacks the required read:org
    permission scope. When attempting to authenticate with GitHub CLI using gh auth login --with-token,
    the token validation failed with the error message: "error validating token: missing required scope
    'read:org'" (line 191).

    Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    22:  Issues: write
    23:  Metadata: read
    24:  Models: read
    25:  Packages: write
    26:  Pages: write
    27:  PullRequests: write
    28:  RepositoryProjects: write
    29:  SecurityEvents: write
    30:  Statuses: write
    31:  ##[endgroup]
    32:  Secret source: Actions
    33:  Prepare workflow directory
    34:  Prepare all required actions
    35:  Getting action download info
    36:  Download action repository 'actions/checkout@main' (SHA:85e6279cec87321a52edac9c87bce653a07cf6c2)
    37:  Complete job name: Rerun workflow when failure
    38:  ##[group]Run actions/checkout@main
    ...
    
    42:  ssh-strict: true
    43:  ssh-user: git
    44:  persist-credentials: true
    45:  clean: true
    46:  sparse-checkout-cone-mode: true
    47:  fetch-depth: 1
    48:  fetch-tags: false
    49:  show-progress: true
    50:  lfs: false
    51:  submodules: false
    52:  set-safe-directory: true
    53:  env:
    54:  GH_CLI_TOKEN: ***
    55:  GH_CLI_TOKEN_PR: ***
    56:  RUN_ID: 14018596811
    57:  RERUN_FAILED_ONLY: true
    58:  RUN_ATTEMPT: 1
    ...
    
    113:  Or undo this operation with:
    114:  git switch -
    115:  Turn off this advice by setting config variable advice.detachedHead to false
    116:  HEAD is now at a7659e5 Merge 268f4af0ec53e035cf02b17832de36a7c19d6f90 into bcf67687384ee2b1f461c82cb54df21f486cbfaf
    117:  ##[endgroup]
    118:  [command]/usr/bin/git log -1 --format=%H
    119:  a7659e503960601eae2b39fe3006718dc742a23c
    120:  ##[group]Run sudo apt update
    121:  �[36;1msudo apt update�[0m
    122:  �[36;1msudo apt install gh�[0m
    123:  shell: /usr/bin/bash -e {0}
    124:  env:
    125:  GH_CLI_TOKEN: ***
    126:  GH_CLI_TOKEN_PR: ***
    127:  RUN_ID: 14018596811
    128:  RERUN_FAILED_ONLY: true
    129:  RUN_ATTEMPT: 1
    ...
    
    173:  Reading state information...
    174:  54 packages can be upgraded. Run 'apt list --upgradable' to see them.
    175:  WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
    176:  Reading package lists...
    177:  Building dependency tree...
    178:  Reading state information...
    179:  gh is already the newest version (2.68.1).
    180:  0 upgraded, 0 newly installed, 0 to remove and 54 not upgraded.
    181:  ##[group]Run echo "$GH_CLI_TOKEN_PR" | gh auth login --with-token
    182:  �[36;1mecho "$GH_CLI_TOKEN_PR" | gh auth login --with-token�[0m
    183:  shell: /usr/bin/bash -e {0}
    184:  env:
    185:  GH_CLI_TOKEN: ***
    186:  GH_CLI_TOKEN_PR: ***
    187:  RUN_ID: 14018596811
    188:  RERUN_FAILED_ONLY: true
    189:  RUN_ATTEMPT: 1
    190:  ##[endgroup]
    191:  error validating token: missing required scope 'read:org'
    192:  ##[error]Process completed with exit code 1.
    193:  Post job cleanup.
    

    @VietND96 VietND96 merged commit b42ce9c into trunk Mar 23, 2025
    26 of 28 checks passed
    @VietND96 VietND96 deleted the 4.30.0 branch March 23, 2025 12:50
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant