Sherif akoush/quickfix/improve docs #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sakoush
commented
Aug 3, 2021
•
sakoush
commented
- Improve docs with regards to testing
- Restrict the version of python to>= 3.7
- added tests for python 3.7, 3.8 and 3.9
added 8 commits
August 3, 2021 17:08
adriangonz
reviewed
Aug 4, 2021
| @@ -0,0 +1,5 @@ | |||
| channels: | |||
There was a problem hiding this comment.
Since we're gonna start using this one, should we remove the existing conda.yaml.tmp file (or rename this one) to avoid confusion in the future?
There was a problem hiding this comment.
yeah I wasnt sure if it is needed somewhere else. ok
added 2 commits
August 4, 2021 13:54
adriangonz
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.