Fix/pd variance plot test coverage #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailed before because of simple explanation values.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
==========================================
+ Coverage 76.37% 81.05% +4.67%
==========================================
Files 73 73
Lines 8477 8475 -2
==========================================
+ Hits 6474 6869 +395
+ Misses 2003 1606 -397
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jklaise
reviewed
Nov 17, 2022
|
|
||
| @pytest.mark.parametrize('n_axes', [4, 5, 6, 7]) | ||
| @pytest.mark.parametrize('n_cols', [2, 3, 4]) | ||
| @pytest.mark.parametrize('exp', [lazy_fixture('explanation_importance')]) |
There was a problem hiding this comment.
Not sure why this needs to be a lazy fixture since it doesn't have it any parameters, can't test functions just depend on this fixture directly as usual?
There was a problem hiding this comment.
Yes ... I think initially I intended to use both types of explanations in the test ... I will update it.
jklaise
reviewed
Nov 17, 2022
jklaise
approved these changes
Nov 18, 2022
RobertSamoilescu
added a commit
to RobertSamoilescu/alibi
that referenced
this pull request
Jan 4, 2023
* Fixed minor bug for conditional plots. * Included importance explanation fixture. * Included interaction explanation fixture. * Included test for hbar ncols. Solved flake8 issues. * Included value error ax for hbar plot. * Included interaction plot tests. * Included plot_pd_variance tests. * Updated the explanation objects with random values. Fixed test that failed before because of simple explanation values. * More random values. * Removed lazy fixture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes tests for the potting functionality of the
PartialDependenceVarianceexplainer to increase coverage (i.e. addresses #760 ).