Skip to content

Add support to schema editor for cloning table into schema #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

Photonios
Copy link
Member

@Photonios Photonios commented Apr 5, 2023

This will not be a documented feature. It has too many ways to shoot yourself in the foot. Consider it an experimental addition that is nicely tucked away.

I want to evolve this over time slowly and use it to build confidence that the approach is solid before committing to supporting it.

What this does

Adds support for cloning a table with the same name into a schema in three steps:

  1. Clone just the columns
  2. Add the indices & constraints
  3. Validate the constraints

They're explicitly three separate steps so the caller can do things in-between them. For example, between step 1 and 2, it can write data to the table quickly without paying the overhead of updating the indices for each row.

@Photonios Photonios force-pushed the model-like branch 13 times, most recently from faa838a to a833018 Compare April 7, 2023 13:48
@Photonios Photonios force-pushed the model-like branch 5 times, most recently from 63e6734 to 2f0245a Compare April 10, 2023 12:18
@Photonios Photonios merged commit 6eff3f1 into master Apr 11, 2023
@Photonios Photonios deleted the model-like branch April 11, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant