Skip to content

Add function for custom format + tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gmuraru
Copy link

@gmuraru gmuraru commented Feb 11, 2020

Fixes #8

Change List:

  • add a set_fmt function to the simple and colored logger such to set custom formats for the output log message
  • add tests for simple and colored logger for testing the functionality

@gmuraru gmuraru requested a review from SebiSebi February 11, 2020 17:46
@gmuraru
Copy link
Author

gmuraru commented Feb 11, 2020

@SebiSebi you still want to offer support for Python2?

@gmuraru gmuraru force-pushed the add-custom-logger-format branch from 3c791d6 to 5f56b18 Compare February 12, 2020 06:21
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #9 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   98.87%   98.98%   +0.11%     
==========================================
  Files           5        5              
  Lines          89       99      +10     
  Branches        5        5              
==========================================
+ Hits           88       98      +10     
  Partials        1        1
Impacted Files Coverage Δ
friendlylog/colored_logger.py 98% <100%> (+0.22%) ⬆️
friendlylog/simple_logger.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e8e4e...3227053. Read the comment docs.

@gmuraru gmuraru force-pushed the add-custom-logger-format branch from 5f56b18 to c8cf4e2 Compare February 12, 2020 06:27
@gmuraru
Copy link
Author

gmuraru commented Feb 12, 2020

Now it should work also for Python 2.7, but maybe it is a good idea to not provide back compatibility anymore since Python2 is dead :(

@gmuraru gmuraru force-pushed the add-custom-logger-format branch from 03724c8 to ff40023 Compare February 12, 2020 07:49
@gmuraru gmuraru force-pushed the add-custom-logger-format branch from ff40023 to 3d07cc7 Compare February 12, 2020 07:50
@mark-bixler
Copy link

Wondering if this PR will ever be approved? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function to hide or customize time / date dump because of long paths or classes names
2 participants