Skip to content

Allow blob name overriding #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Allow blob name overriding #180

merged 2 commits into from
Feb 28, 2020

Conversation

SeanFeldman
Copy link
Owner

@SeanFeldman SeanFeldman commented Feb 28, 2020

Closes #178
Replaces #179

The approach taken here is to add an extension method w/o modifying AzureStorageAttachmentConfiguration. Blob name is not something that many users tend to override (so far there were no requests) and adding it as a parameter, event as an optional one, feels unnecessary. Instead, a specific extension method is added to achieve the same goal.

For the testing, having a single test to verify messages can be sent and received using a blob name override is enough.

Documentation updated to show the usage.

@SeanFeldman SeanFeldman self-assigned this Feb 28, 2020
@SeanFeldman
Copy link
Owner Author

@SeanFeldman SeanFeldman marked this pull request as ready for review February 28, 2020 00:48
@SeanFeldman SeanFeldman merged commit a1f0dbb into develop Feb 28, 2020
@SeanFeldman SeanFeldman deleted the override-blob-name branch February 28, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support customization of attachment names in blob storage
1 participant