Skip to content

Add banUser & unbanUser #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Mar 17, 2025

No description provided.

@AlinaNova21
Copy link
Member

Just setting active to 0 is not enough, this happens to users sometimes anyway. https://github.com/ScreepsMods/screepsmod-admin-utils/blob/master/lib%2Fcronjobs%2FinactiveUserCleanup.js

@AlinaNova21
Copy link
Member

An alternative would probably be set banned to true and adjust the whitelist cron to check it as well.

@tiennou
Copy link
Contributor Author

tiennou commented Mar 18, 2025

An alternative would probably be set banned to true and adjust the whitelist cron to check it as well.

blocked or banned? I don't think banned is a thing right now, but blocked has a couple references around.

@AlinaNova21
Copy link
Member

cant set blocked since the whitelist cron would overwrite it, instead, can add banned (it doesnt exist, but can be added anyway), then have the whitelist check it when setting blocked.

@tiennou
Copy link
Contributor Author

tiennou commented Mar 19, 2025

Okay, updated to set banned on the user along with active: 0 to stop their processing. I've checked that even in the whitelist, a banned user stays disabled.

@tiennou tiennou force-pushed the feature/user-ban branch from a9de461 to 42a481e Compare May 23, 2025 16:41
@tiennou tiennou force-pushed the feature/user-ban branch from 42a481e to 1ce80d1 Compare May 23, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants