Skip to content

Bump dependencies, add Ruby 3.3 to test matrix #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

RSO
Copy link
Contributor

@RSO RSO commented Jul 31, 2024

httparty 0.21.0 is throwing deprecation warnings in Rails on ruby 3.3:

~/.rbenv/versions/3.3.2/lib/ruby/gems/3.3.0/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30: warning: ~/.rbenv/versions/3.3.2/lib/ruby/3.3.0/csv.rb was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of httparty-0.21.0 to add csv into its gemspec.

This PR adds testing for Ruby 3.3, and changes the httparty dependency to ~> 0.22.0.

@ScotterC
Copy link
Owner

ScotterC commented Aug 6, 2024

Thanks for the submission!

@ScotterC
Copy link
Owner

ScotterC commented Aug 6, 2024

Looks like the side effect of the the other bundle updates are linting errors :/

@RSO
Copy link
Contributor Author

RSO commented Aug 9, 2024

Let me see if I can make it so that this only upgrade httparty!

@RSO RSO force-pushed the upgrade-dependencies branch from a26d765 to 79ae972 Compare August 9, 2024 06:57
@RSO
Copy link
Contributor Author

RSO commented Aug 9, 2024

This should now be ready for review/merge again!

@ScotterC
Copy link
Owner

ScotterC commented Aug 9, 2024

Thanks!

@ScotterC ScotterC merged commit 8e80418 into ScotterC:main Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants