Skip to content

bitwarden-cli: Persist data #6462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ra2-IFV
Copy link
Contributor

@Ra2-IFV Ra2-IFV commented Jan 16, 2025

Reopen for #6219
See bitwarden/cli#117

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

bitwarden-cli

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@HUMORCE
Copy link
Member

HUMORCE commented Apr 16, 2025

Will the dir creation make users open a empty database without a migration?

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Apr 17, 2025

Yeah I guess so so I asked if I could write a script to migrate the data

@HUMORCE
Copy link
Member

HUMORCE commented Apr 17, 2025

If it does NOT cause the database to disappear, memo this change in notes is enought.

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Apr 17, 2025

any examples of telling users how to do that? I'm not good at this

@HUMORCE
Copy link
Member

HUMORCE commented Apr 17, 2025

It might look like:

"notes": [
  "The data location has been persisted by Scoop since <version>",
  "Previous location: ...",
  "Current location: ..."
],

for more examples, searching "notes" on main/extras repo via VS Code.

@Ra2-IFV Ra2-IFV force-pushed the feat_bitwarden-cli_add-persist branch from 332c057 to 64fe56a Compare April 17, 2025 12:00
@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Apr 17, 2025

Done. Also please take a look at ScoopInstaller/Extras#15311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants