Skip to content

Cinnamon spices #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 9, 2025
Merged

Cinnamon spices #4690

merged 6 commits into from
May 9, 2025

Conversation

JEleniel
Copy link
Contributor

@JEleniel JEleniel commented May 8, 2025

JEleniel and others added 5 commits February 14, 2025 10:32
Copy link
Contributor

github-actions bot commented May 8, 2025

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@JEleniel
Copy link
Contributor Author

JEleniel commented May 8, 2025

I'm not sure why the cli.js check is failing. The entry is in the catalog and passes locally:

$ node ./cli.js check --schema-name=cinnamon-spice.info.json
===== VALIDATE PRECONDITIONS =====
✔️ Directory structure conforms to expected layout
✔️ catalog.json validates against its schema
✔️ catalog.json has no fields that break guidelines
✔️ catalog.json has no duplicate "fileMatch" values
✔️ catalog.json has no invalid schema URLs
✔️ schema-validation.jsonc validates against its schema
✔️ schema-validation.jsonc has no invalid schema names
✔️ schema-validation.jsonc has no invalid schema URLs
✔️ schema-validation.jsonc has no invalid skiptest[] entries
===== VALIDATE SCHEMAS =====
✔️ Completed "pre-checks"
✔️ Completed "Ajv validation"
===== REPORT =====
Out of 1473 TOTAL schemas:
- 671 (46%) are SchemaStore URLs
- 802 (54%) are External URLs

Out of 674 TESTED schemas:
- 276 (41%) are validated with Ajv's strict mode
- 180 (27%) do not have tests.
- 558 (83%) do not have negative tests.
Out of 1 TESTED schemas:
- Total  2020-12: 0
- Total  2019-09: 0
- Total draft-07: 1
- Total draft-06: 0
- Total draft-04: 0
- Total draft-03: 0

@hyperupcall
Copy link
Member

Thanks! The mismatch seems to stem from the branch being based off 883f78a, a commit from Feb 14, while GitHub actions is based on HEAD.

The error message could be improved, but it seems like "url" was meant to begin with https://json.schemastore.org instead of https://json-schema.org?

@hyperupcall
Copy link
Member

Great, thanks!.

@hyperupcall hyperupcall merged commit 7d692e7 into SchemaStore:master May 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants