Skip to content

[Resolve #1520] Fix test for cmd hook shell option #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Resolve #1520] Fix test for cmd hook shell option #1552

wants to merge 1 commit into from

Conversation

iainelder
Copy link
Contributor

The previous version of this test meant to use bash, but really used sh.

Improves first PR #1523.

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

@iainelder
[Resolve Sceptre#1520] Fix test for cmd hook shell option
ba35356 
The previous version of this test meant to use bash, but really
used sh.

Improves first PR Sceptre#1523.
@iainelder iainelder requested a review from dboitnot April 4, 2025 15:17
@iainelder
Copy link
Contributor Author

@dboitnot , does this still work on Nix?

@zaro0508 zaro0508 requested a review from alex-harvey-z3q April 4, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-harvey-z3q alex-harvey-z3q alex-harvey-z3q approved these changes

@dboitnot dboitnot Awaiting requested review from dboitnot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iainelder @alex-harvey-z3q