feat: set thread name #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daeyeon
reviewed
May 8, 2025
deps/node/src/node.cc
Outdated
| @@ -1051,6 +1051,7 @@ InitializationResult InitializeOncePerProcess(int argc, char** argv) { | |||
| V8::SetEntropySource(crypto::EntropySource); | |||
| #endif // HAVE_OPENSSL | |||
|
|
|||
| uv_thread_setname("lwnode::Main"); // @lwnode | |||
There was a problem hiding this comment.
Suggested change
| uv_thread_setname("lwnode::Main"); // @lwnode | |
| uv_thread_setname("MainThread"); // @lwnode |
deps/node/src/node_platform.cc
Outdated
| @@ -27,7 +27,7 @@ struct PlatformWorkerData { | |||
| static void PlatformWorkerThread(void* data) { | |||
| std::unique_ptr<PlatformWorkerData> | |||
| worker_data(static_cast<PlatformWorkerData*>(data)); | |||
|
|
|||
| uv_thread_setname("lwnode::PT"); | |||
There was a problem hiding this comment.
Suggested change
| uv_thread_setname("lwnode::PT"); | |
| uv_thread_setname("V8Worker"); |
deps/node/src/node_platform.cc
Outdated
Comment on lines
57
to
58
| uv_thread_setname("lwnode::DTask"); | ||
| printf("Starting delay thread\n"); |
There was a problem hiding this comment.
Suggested change
| uv_thread_setname("lwnode::DTask"); | |
| printf("Starting delay thread\n"); | |
| uv_thread_setname("V8Worker"); |
deps/node/deps/uv/src/threadpool.c
Outdated
Comment on lines
57
to
58
| static void worker(void* arg) { | ||
| uv_thread_setname("lwnode::uv"); |
There was a problem hiding this comment.
Suggested change
| static void worker(void* arg) { | |
| uv_thread_setname("lwnode::uv"); | |
| static void worker(void* arg) { |
There was a problem hiding this comment.
IMO, naming here isn’t ideal. Naming for debugging should be set at the higher level that uses uv.
src/lwnode/lwnode-gc-strategy.cc
Outdated
| @@ -45,6 +47,7 @@ void DelayedGC::handle(v8::Isolate* isolate) { | |||
|
|
|||
| if (state_ == DelayedGCState::TIMER_END) { | |||
| std::thread([&]() { | |||
| uv_thread_setname("lwnode::gc"); | |||
There was a problem hiding this comment.
Suggested change
| uv_thread_setname("lwnode::gc"); | |
| uv_thread_setname("ScheduleGC"); |
| @@ -1763,6 +1763,7 @@ UV_EXTERN int uv_thread_create_ex(uv_thread_t* tid, | |||
| void* arg); | |||
| UV_EXTERN uv_thread_t uv_thread_self(void); | |||
| UV_EXTERN int uv_thread_join(uv_thread_t *tid); | |||
| UV_EXTERN int uv_thread_setname(const char* name); | |||
There was a problem hiding this comment.
Suggested change
| UV_EXTERN int uv_thread_setname(const char* name); | |
| // @lwnode | |
| UV_EXTERN int uv_thread_setname(const char* name); |
Does this API need the // @lwnode tag like uv_watcher_queue_empty?
Signed-off-by: Hosung Kim [email protected]
daeyeon
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hosung Kim [email protected]