Skip to content

Merged Monitoring and Monitoring Service into one #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DarrenDsouza7273
Copy link

@DarrenDsouza7273 DarrenDsouza7273 commented Jun 14, 2024

  • Merge monitor and monitoringService commands in cli into one

  • First level implementation on skipDocker command

    • for v0.0.1 make it work with the merged monitor command to allow for opting in and out of docker setup.
  • Fixes issue : Merge monitor and monitoringService commands #30

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

(#30 (comment))

Copy link
Collaborator

@sooraj1002 sooraj1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is only removing monitoringService from the cli, it is not merging the functionality previously provided by it into monitoring

@sooraj1002
Copy link
Collaborator

The schematics should also be updated to merge monitorModule and monitor into one command like monitoring.

@DarrenDsouza7273
Copy link
Author

DarrenDsouza7273 commented Jun 15, 2024

@sooraj1002 Yes ill work on your reviewed suggestions and do the respective changes
also i have added draft skipDocker flag

@DarrenDsouza7273
Copy link
Author

image
skip-Docker - Visual Studio Code 16-06-2024 15_39_29
it even works with other Flags


await createMonitor(
await createskipDocker(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is workable, but this feature should ideally be handled in combination with changes in the schematics as well since the bootstrapping is just one part of the system.

What happens when a user wants to generate monitoring related files? they would need to run two commands, nest g monitor and nest g monitorModule whereas it should ideally be implemented something as nest g monitor --skipDocker. The flag should be implemented at the level of each schematic, and while bootstrapping a new project, the --skipDocker flag should be propagated to each command

@Savio629
Copy link
Collaborator

Fixes/included in pr #34

@Savio629 Savio629 closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants