Skip to content

feat(responsive-vertical-menu): allows custom aria-label for menu launcher #7367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damienrobson-sage
Copy link
Contributor

Proposed behaviour

  • ResponsiveVerticalMenu now allows an additional prop to set the value of aria-label;
  • The ResponsiveVerticalMenuDivider is now exported correctly

Current behaviour

  • The launcher button for the ResponsiveVerticalMenu is announced via the name of the icon used, with no additional context;
  • The ResponsiveVerticalMenuDivider isn't exported for use

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Testing instructions

Use the Without Global Header test story to verify that Main menu is announced when focus is gained and a screen reader is active

mihai-albu-sage
mihai-albu-sage previously approved these changes Jun 9, 2025
mihai-albu-sage
mihai-albu-sage previously approved these changes Jun 9, 2025
edleeks87
edleeks87 previously approved these changes Jun 10, 2025
Copy link
Contributor

@edleeks87 edleeks87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth doing the same for this before we send it off to the translation team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants