feat(responsive-vertical-menu): allows custom aria-label for menu launcher #7367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
ResponsiveVerticalMenu
now allows an additional prop to set the value ofaria-label
;ResponsiveVerticalMenuDivider
is now exported correctlyCurrent behaviour
ResponsiveVerticalMenu
is announced via the name of the icon used, with no additional context;ResponsiveVerticalMenuDivider
isn't exported for useChecklist
d.ts
file added or updated if requiredQA
Testing instructions
Use the
Without Global Header
test story to verify thatMain menu
is announced when focus is gained and a screen reader is active