-
Notifications
You must be signed in to change notification settings - Fork 82
feat(responsive-vertical-menu): allows custom aria-label for menu launcher #7367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihai-albu-sage
previously approved these changes
Jun 9, 2025
edleeks87
reviewed
Jun 9, 2025
src/components/vertical-menu/responsive-vertical-menu/responsive-vertical-menu.component.tsx
Outdated
Show resolved
Hide resolved
src/components/vertical-menu/responsive-vertical-menu/responsive-vertical-menu.component.tsx
Outdated
Show resolved
Hide resolved
444d740
to
f7d2db2
Compare
mihai-albu-sage
previously approved these changes
Jun 9, 2025
edleeks87
previously approved these changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth doing the same for this before we send it off to the translation team
8826e66
f7d2db2
to
8826e66
Compare
mihai-albu-sage
approved these changes
Jun 10, 2025
edleeks87
approved these changes
Jun 10, 2025
paulrobinson88
approved these changes
Jun 11, 2025
🎉 This PR is included in version 154.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
ResponsiveVerticalMenu
now allows an additional prop to set the value ofaria-label
;ResponsiveVerticalMenuDivider
is now exported correctlyCurrent behaviour
ResponsiveVerticalMenu
is announced via the name of the icon used, with no additional context;ResponsiveVerticalMenuDivider
isn't exported for useChecklist
d.ts
file added or updated if requiredQA
Testing instructions
Use the
Without Global Header
test story to verify thatMain menu
is announced when focus is gained and a screen reader is active