Skip to content

fix(note): render title semantically with h3 when passed as text #7360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DobroTora
Copy link
Contributor

@DobroTora DobroTora commented Jun 3, 2025

Proposed behaviour

title prop in Note component renders using Typography with variant="h3"

Current behaviour

Styling for H3 for a title prop is being overwritten in a Note component within with title story.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@DobroTora DobroTora requested review from a team as code owners June 3, 2025 14:50
@DobroTora DobroTora changed the title FE7256 Note fix(note): render title semantically with h3 when passed as text Jun 3, 2025
@DobroTora DobroTora force-pushed the FE-7256-Typography branch from c4c1eb5 to 88ab78b Compare June 3, 2025 15:28
padding-bottom: 16px;
}
`,
${variant}{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: should set the styles to default to those of h3 now

If we are to still support this behaviour then this should be defaulted to the h3 styling (previously it was h2 styling). It might be worth speaking to the team to ensure that we want to keep this behaviour as it's not completely clear from the ticket.

We also need to ensure the DS is updated as this no longer matches what is supposed to be the source of truth. So, it could be worth speaking to @harpalsingh to make sure that gets updated if this is to be correct. I'd be reluctant to approve this until it does match the source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants