fix(date, date-range): ensure date format override returns correct formatted value #7359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuria1110
commented
Jun 2, 2025
There was a problem hiding this comment.
Looks like James was correct here and we should be generating the list of formats to match from the override string and not from the locale format, which is what was causing the mismatch when day and month values were swapped.
Parsium
previously approved these changes
Jun 4, 2025
| "de-DE": de, | ||
| }; | ||
|
|
||
| export const I18NStory = ({ locale, ...args }: DateInputI80NProps) => { |
There was a problem hiding this comment.
praise: nice idea using Storybook Controls to change the locale for testing 👍
edleeks87
reviewed
Jun 5, 2025
src/components/date/__internal__/date-formats/date-formats.test.ts
Outdated
Show resolved
Hide resolved
…rmatted value When overridding the default date format, the format was not always respected and would switch to the default in some cases where the day and month were flipped. fix #7345
edleeks87
approved these changes
Jun 5, 2025
Parsium
approved these changes
Jun 5, 2025
dariusbercea-sage
approved these changes
Jun 9, 2025
|
🎉 This PR is included in version 154.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7345
Proposed behaviour
dateFormatOverrideprop and translation key can be used, with the prop taking precedence.Screen.Recording.2025-06-02.at.16.57.54.mov
Current behaviour
dateFormatOverrideprop has no effect.dateFormatOverridetranslation key, it fails to format values correctly and parse correct raw value for theonChangeevent, specially when the day and month are flipped.Using de-DE locale:
Screen.Recording.2025-06-02.at.16.50.50.mov
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
i18n Storytest story in storybook and changing thedateFormatOverride, see actions for returned formatted and raw values.03-06-2019should update to03/06/2019if date format isdd/MM/yyyy.