Skip to content

MenuItem: change submenu prop to accept a ReactNode #7353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
darceykelly opened this issue May 29, 2025 · 4 comments · Fixed by #7369
Closed
1 task done

MenuItem: change submenu prop to accept a ReactNode #7353

darceykelly opened this issue May 29, 2025 · 4 comments · Fixed by #7369
Labels
Enhancement On Backlog released

Comments

@darceykelly
Copy link

Description

I want the submenu prop on the MenuItem component to accept a ReactNode so that I can use the Portrait component as part of the title of a submenu

Suggested solution

Allow submenu to accept ReactNode

Demo URL

No response

Alternatives

No response

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@darceykelly darceykelly added Enhancement triage Triage Required labels May 29, 2025
@edleeks87
Copy link
Contributor

I've discussed this with @harpalsingh and UX are keen for support to be added

cc @ljemmo

@ljemmo
Copy link
Contributor

ljemmo commented Jun 2, 2025

happy from a DS perspective to add support for this @edleeks87 we hav a DS / Carbon ticket on our backlog to add support.

@tomdavies73 tomdavies73 added On Backlog and removed triage Triage Required labels Jun 3, 2025
@tomdavies73
Copy link
Contributor

FE-7278

tomdavies73 added a commit that referenced this issue Jun 6, 2025
@tomdavies73
feat(menu-item): allow nodes to be passed to the submenu prop
78f3a8a 
The `submenu` prop on `MenuItem` now accepts a node, which ensures consumers can create complex
compositions for the title with non-interactive elements when the `MenuItem` has a submenu

fix #7353
@tomdavies73 tomdavies73 mentioned this issue Jun 6, 2025
Merged
14 tasks
tomdavies73 added a commit that referenced this issue Jun 6, 2025
@tomdavies73
feat(menu-item): allow nodes to be passed to the submenu prop
073d462 
The `submenu` prop on `MenuItem` now accepts a node, which ensures consumers can create complex
compositions for the title with non-interactive elements when the `MenuItem` has a submenu

fix #7353
tomdavies73 added a commit that referenced this issue Jun 9, 2025
@tomdavies73
feat(menu-item): allow nodes to be passed to the submenu prop
b12e6c6 
The `submenu` prop on `MenuItem` now accepts a node, which ensures consumers can create complex
compositions for the title with non-interactive elements when the `MenuItem` has a submenu

fix #7353
tomdavies73 added a commit that referenced this issue Jun 9, 2025
@tomdavies73
feat(menu-item): allow nodes to be passed to the submenu prop
0faf225 
The `submenu` prop on `MenuItem` now accepts a node, which ensures consumers can create complex
compositions for the title with non-interactive elements when the `MenuItem` has a submenu

fix #7353
tomdavies73 added a commit that referenced this issue Jun 16, 2025
@tomdavies73
feat(menu-item): allow nodes to be passed to the submenu prop
d97094c 
The `submenu` prop on `MenuItem` now accepts a node, which ensures consumers can create complex
compositions for the title with non-interactive elements when the `MenuItem` has a submenu

fix #7353
carbonci pushed a commit that referenced this issue Jun 16, 2025
@semantic-release-bot @carbonci
chore(release): 154.10.0
a0445b2 
## [154.10.0](v154.9.0...v154.10.0) (2025-06-16)

### Features

* **menu-item:** allow nodes to be passed to the submenu prop ([d97094c](d97094c)), closes [#7353](#7353)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 154.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement On Backlog released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(menu-item): allow nodes to be passed to the submenu prop Sage/carbon
5 participants
@edleeks87 @carbonci @ljemmo @tomdavies73 @darceykelly