Skip to content

Update section on identifiers #257 #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2024
Merged

Update section on identifiers #257 #288

merged 1 commit into from
Mar 7, 2024

Conversation

dariavladykina
Copy link
Contributor

Updated the section on identifiers in "Structure" #257
Added regex pattern, enhanced wording.

@dariavladykina dariavladykina marked this pull request as ready for review February 21, 2024 11:47
janajaeger
janajaeger approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@janajaeger janajaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the regex thing is not wrong, it might confuse a few readers. But then again, it might also educate them on the subject of regex :-P

@dariavladykina
Copy link
Contributor Author

They can google it just like I did (to make sure it is immediately findable :-) )

jfaltenbacher
jfaltenbacher approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@jfaltenbacher jfaltenbacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dariavladykina dariavladykina merged commit c9de6d8 into main Mar 7, 2024
@dariavladykina dariavladykina deleted the vlada/update_sec_identifiers branch March 7, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PadraigDillon1 PadraigDillon1 PadraigDillon1 approved these changes

@jfaltenbacher jfaltenbacher jfaltenbacher approved these changes

@janajaeger janajaeger janajaeger approved these changes

@cwickert cwickert Awaiting requested review from cwickert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dariavladykina @PadraigDillon1 @jfaltenbacher @janajaeger