Skip to content

[FIX] Implemented Settings Page from #84 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2024
Merged

[FIX] Implemented Settings Page from #84 #94

merged 1 commit into from
May 20, 2024

Conversation

yashmandi
Copy link
Contributor

Description

  • Implemented the 'Settings' Page. Now, when you click on 'Settings' icon from the sidebar, you'll route to settings page, i.e. /settings
  • I've used the 'React Router DOM' to route the pages, due to which made some changes in app,js
  • Implemented multiple tabs section in Settings Page

Type of PR

  • Feature enhancement

Screenshots / videos (if applicable)

settings-tab.mp4

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Would you mind considering assigning a level3 tag to this issue? It was quite challenging to resolve. It's entirely up to you;
I understand either way. 😉
Meanwhile, let me know if i have to make any changes in this page.

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uni-collab ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 2:47pm
uni-collab-kxfl ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 2:47pm
unicollab ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 2:47pm

@SUGAM-ARORA
Copy link
Owner

Fixes #84

@SUGAM-ARORA
Copy link
Owner

Description

  • Implemented the 'Settings' Page. Now, when you click on 'Settings' icon from the sidebar, you'll route to settings page, i.e. /settings
  • I've used the 'React Router DOM' to route the pages, due to which made some changes in app,js
  • Implemented multiple tabs section in Settings Page

Type of PR

  • Feature enhancement

Screenshots / videos (if applicable)

settings-tab.mp4

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Would you mind considering assigning a level3 tag to this issue? It was quite challenging to resolve. It's entirely up to you; I understand either way. 😉 Meanwhile, let me know if i have to make any changes in this page.

Actually after I saw your edits I by default changed it to level3

@SUGAM-ARORA
Copy link
Owner

Great work.
@yashmandi Just one thing more . Do add Fixes #Issue_Number

Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @yashmandi

@SUGAM-ARORA SUGAM-ARORA merged commit e1f5919 into SUGAM-ARORA:main May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC 2024 hard
Projects
Development

Successfully merging this pull request may close these issues.

2 participants