Skip to content

Created a responsive hamburger menu , added animation to it , fixed width , added cross button #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

Ayushmaanagarwal1211
Copy link
Contributor

@Ayushmaanagarwal1211 Ayushmaanagarwal1211 commented Aug 8, 2024

Related Issue

Fixes #678

Description

In this pr i have added the opening animation to the hamburger menu
Added The cross button so that when mob menu shows then the cross button will come
Changes the color of the hamburger menu according to the theme
Some fixed in responsive of the header as well

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

bandicam.2024-08-08.22-44-40-742.mp4

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uni-collab ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 5:59pm

Copy link

github-actions bot commented Aug 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Ayushmaanagarwal1211 Ayushmaanagarwal1211 changed the title Created a responsivehamburger menu Created a responsive hamburger menu , added animation to it , fixed width , added cross button Aug 8, 2024
Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayushmaanagarwal1211 Update branch

@Ayushmaanagarwal1211
Copy link
Contributor Author

@SUGAM-ARORA Done

Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@SUGAM-ARORA SUGAM-ARORA added gssoc GSSOC 2024 easy labels Aug 8, 2024
@SUGAM-ARORA SUGAM-ARORA merged commit 8e5ad81 into SUGAM-ARORA:main Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy gssoc GSSOC 2024
Projects
Development

Successfully merging this pull request may close these issues.

Feat: Want to add hamburger Menu
2 participants