Skip to content

Resolved Alignment Issue #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

Sneha0019
Copy link
Contributor

@Sneha0019 Sneha0019 commented Jun 15, 2024

Related Issue

Fixes #268

Description

So basically, I was assigned to resolve the issues of Alignment as same it was earlier. Like added flex, made changes in main_img height
So I changed alignment of card and the statistics points from blue to red, also increased the fontWeight of heading "Statistics".
Similarly, I made changes in the Top contributor part by making color of font from blue to red as required.
Overall, main changes were in container.css file of the project.

Type of PR

  • Feature enhancement

Screenshots / videos (if applicable)

Screen Recording -
https://github.com/SUGAM-ARORA/UniCollab/assets/112338459/15f57da6-be56-4314-b596-e473ad0dc160

Screenshot of changes made in main page
image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uni-collab ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 7:12pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sneha0019 Just do branch updation.
Check Branch Update File

@Sneha0019
Copy link
Contributor Author

Sneha0019 commented Jun 15, 2024

All the branches are up-to-date
image

And the changes are live in deployed website on vercel
image

I request you to review and close this issue!

@Sneha0019 Sneha0019 requested a review from SUGAM-ARORA June 15, 2024 19:46
@SUGAM-ARORA
Copy link
Owner

@Sneha0019 Firstly go to your cloned github repo and update the branch . Then use the above commands

@Sneha0019
Copy link
Contributor Author

I have done the changes as required and update the branch!

image

Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sneha0019 Still branch not up to date. Follow the following steps :

  1. Go to the cloned github repo on browser and then click on sync fork and update branch . sample i have shared below
    image
  2. after doing this now follow the steps

@Sneha0019
Copy link
Contributor Author

Thank you so much for guiding me I have done the changes!

Step 1:-
image

Step 2:-
image

@Sneha0019 Sneha0019 requested a review from SUGAM-ARORA June 17, 2024 19:18
Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Sneha0019
Copy link
Contributor Author

Thank you!

@SUGAM-ARORA SUGAM-ARORA merged commit 8c188d7 into SUGAM-ARORA:main Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC 2024 medium
Projects
Development

Successfully merging this pull request may close these issues.

Alignment issue
2 participants