Skip to content

Updated Footer #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Updated Footer #223

merged 4 commits into from
Jun 3, 2024

Conversation

Hemashree21
Copy link
Contributor

@Hemashree21 Hemashree21 commented Jun 3, 2024

Resolved issue #178

image

image

Screenshot 2024-06-03 161443

@SUGAM-ARORA I have updated the footer and made it responsive. please check and let me know if any changes are required

Signed-off-by: Hemashree M S <[email protected]>
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uni-collab ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 11:34am

Copy link

github-actions bot commented Jun 3, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@SUGAM-ARORA
Copy link
Owner

@Hemashree21 Just update the spacing issue at the bottom . Right now it is quite much . Reduce this

@Hemashree21
Copy link
Contributor Author

Hemashree21 commented Jun 3, 2024

@SUGAM-ARORA which space the space between social media icons and the copyright?

@SUGAM-ARORA
Copy link
Owner

@SUGAM-ARORA which space the space between social media icons and the copyright?

Yes . It is much more than needed.

Signed-off-by: Hemashree M S <[email protected]>
@Hemashree21
Copy link
Contributor Author

@SUGAM-ARORA I updated it

image

@SUGAM-ARORA
Copy link
Owner

@Hemashree21 Now its better but your branch is still not updated.

@SUGAM-ARORA
Copy link
Owner

Pro feature not visible

@Hemashree21
Copy link
Contributor Author

@SUGAM-ARORA where shall I add the Go Pro button in the Footer? Shall I add it instead of Unicollab since we have the Logo anyway?

@SUGAM-ARORA
Copy link
Owner

@SUGAM-ARORA where shall I add the Go Pro button in the Footer? Shall I add it instead of Unicollab since we have the Logo anyway?

If possible add Go pro at the top (just left of notifications icon)

Signed-off-by: Hemashree M S <[email protected]>
@Hemashree21
Copy link
Contributor Author

@SUGAM-ARORA I updated it, is this fine?

image

@SUGAM-ARORA
Copy link
Owner

@Hemashree21 Impressive

@SUGAM-ARORA SUGAM-ARORA merged commit 3e315ea into SUGAM-ARORA:main Jun 3, 2024
2 checks passed
@Hemashree21
Copy link
Contributor Author

@SUGAM-ARORA do you need legal pages for the website, I can work on it. Shall I raise an issue?

@SUGAM-ARORA
Copy link
Owner

@Hemashree21 Any sample ?

@Hemashree21
Copy link
Contributor Author

Hemashree21 commented Jun 3, 2024

Screenshot 2024-05-26 113812
Screenshot 2024-05-26 113839

@SUGAM-ARORA Something like this

@SUGAM-ARORA
Copy link
Owner

Screenshot 2024-05-26 113812 Screenshot 2024-05-26 113839

@SUGAM-ARORA Something like this

Works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC 2024 hard
Projects
Development

Successfully merging this pull request may close these issues.

2 participants