feat(pagination) added an option to add custom title in pagination bu… #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnlangille
force-pushed
the
v0.17.0
branch
from
7c61760 to
c3068d9
Compare
|
Hey @VojtechKlos thanks for making the contribution, looks like your branch needs a rebase on |
* fix(precommit): use jest exit code * fix(jest): restore coverage collection context * chore(package.json): remove phased out test tools
* fix(carousel): flush the slides left when they don't fill the width (SSENSE#323) * fix(carousel): Flush the slides left when they don't fill the width (SSENSE#323) When there are too few slides to fill the row, with scrollPerPage, the slides were flushed right instead of left. By bounding maxOffest to a minimum of 0, the slides are aligned on the left-hand-side Fix SSENSE#323 * style(play): Use capitals in tests for consistency * v0.16.1 * chore: build * feat(standard): watch autoplay prop and enable/disable autoplay
VojtechKlos
force-pushed
the
feat/custom-titles-in-pagination
branch
from
20d8d74 to
a79b28f
Compare
|
Hey @VojtechKlos, thanks for the cleanup! I'll merge in now 🚀 |
ashleysimpson
approved these changes
Dec 20, 2018
|
@quinnlangille hey, thanks for merging my pr. When is it planned to release version 0.17? |
|
@VojtechKlos should be sometime next week! I'll make a release when it's out, if you're watching the repo you should get a notification |
|
How can i make the title not appearing? I mean i don't want the title tag when hovering dots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow custom titles in carousel pagination.
Description
Extends on the pull request #263 allowing specifying custom title by passing the title prop to the slide component.
Motivation and Context
Sometimes you need custom titles instead of just "Item 0" etc...
How Has This Been Tested?
Just manually. I am not sure how and if to write tests for this.
Screenshots (if appropriate):
Types of changes
Checklist: