feat(accessibility): use correct aria properties #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdminXVII
force-pushed
the
feat-fix-aria
branch
from
bfe94ca to
b7146db
Compare
|
^ resolved some small conflicts caused by the base branch switch |
|
Ah dang looks like this will need a rebase with |
AdminXVII
force-pushed
the
feat-fix-aria
branch
from
7593846 to
b7146db
Compare
AdminXVII
force-pushed
the
feat-fix-aria
branch
from
b7146db to
088c4a0
Compare
Based on [aXe](https://www.deque.com/axe/) recommendations, fix accessibility: - Use proper roles for the various components (ex: role="button" not needed on buttons). - Reorder navigation and pagination to better match the tabbing order. - Make navigation accessible by tabbing. - Change the HTML elements to better match [W3's recommended organization](https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html)
AdminXVII
force-pushed
the
feat-fix-aria
branch
from
088c4a0 to
db2d9ed
Compare
|
Done |
|
Perfect @AdminXVII, will merge into the working branch! Thanks for the upgrade 🚀 |
quinnlangille
pushed a commit
that referenced
this pull request
Dec 19, 2018
* chore: build * feat(accessibility): use correct aria properties Based on [aXe](https://www.deque.com/axe/) recommendations, fix accessibility: - Use proper roles for the various components (ex: role="button" not needed on buttons). - Reorder navigation and pagination to better match the tabbing order. - Make navigation accessible by tabbing. - Change the HTML elements to better match [W3's recommended organization](https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html)
josephting
added a commit
to josephting/vue-carousel
that referenced
this pull request
Dec 20, 2018
* tags adjustments from SSENSE#349 * pre jest-serializer-vue test from SSENSE#322
7 tasks
quinnlangille
pushed a commit
that referenced
this pull request
Dec 27, 2018
* chore: build * feat(accessibility): use correct aria properties Based on [aXe](https://www.deque.com/axe/) recommendations, fix accessibility: - Use proper roles for the various components (ex: role="button" not needed on buttons). - Reorder navigation and pagination to better match the tabbing order. - Make navigation accessible by tabbing. - Change the HTML elements to better match [W3's recommended organization](https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on aXe recommendations, fix accessibility:
Motivation and Context
Accessibility of the carousel.
How Has This Been Tested?
Tested using vue-play in Firefox and Chrome on Linux.
Types of changes
Checklist: