Skip to content

fix(carousel): calculation lastFullPageOffset #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2018

Conversation

dfvc
Copy link
Contributor

@dfvc dfvc commented Dec 11, 2018

It is not possible to reach the last slide by using swipe when navigation is enabled

Description

Before 0.16.0, it was not possible to reach the last slide by using navigation "next" button. Swiping everything worked fine. After update to 0.16.0, this behavor is inverted, i.e., I can reach the last slider by pressing "next" button but not by swiping.
This Pull Request fixes a calculation issue that was creating this unexpected behavior.

Motivation and Context

Fixes issue #345

How Has This Been Tested?

There is already a Vue Play case for this in the project, and was also tested manually in all VuePlay cases

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have included a vue-play example (if this is a new feature)

@quinnlangille quinnlangille changed the base branch from master to v0.17.0 December 19, 2018 22:07
@quinnlangille
Copy link
Member

Looks good @dfvc, will merge now and release with v0.17.0 🚀 - should be out sometime next week

@quinnlangille quinnlangille merged commit 3ad01f0 into SSENSE:v0.17.0 Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants