Add lint-staged to re-stage fixed files in precommit #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work @josephtingm, this has been driving me crazy for a year lol I'll merge right away |
quinnlangille
pushed a commit
that referenced
this pull request
Dec 19, 2018
quinnlangille
pushed a commit
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes fixed by
prettier-eslintaren't staged to the commit.This PR will fix this issue.
lint-staged is used.
Motivation and Context
Eliminate the need to do git commit amend or worst yet, separate commit to push the changes made by
prettier-eslint.How Has This Been Tested?
npm run precommitworks perfectly.Destroying the format in
src/Carousel.vueand then dogit commit -am 'test'will create an empty commit.Types of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.I have included a vue-play example (if this is a new feature)