Add post-install in setup.py that runs patch-activate.sh #552
Assignees
Comments
9 tasks
jesper-friis
added a commit
that referenced
this issue
Jun 21, 2023
Description =========== Added a `patch-activate.sh` script that patches the virtual environment activate script on POSIX systems such that LD_LIBRARY_PATH is set correctly. Forgetting to set LD_LIBRARY_PATH has led to many bugs and issues... Closes #540 Issue #552 is afollow-up of this PR. Type of change -------------- - [ ] Bug fix - [x] New feature - [ ] Documentation update - [ ] Test update Checklist for the reviewer -------------------------- This checklist should be used as a help for the reviewer. - [ ] Is the change limited to one issue? - [ ] Does this PR close the issue? - [ ] Is the code easy to read and understand? - [ ] Do all new feature have an accompanying new test? - [ ] Has the documentation been updated as necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Forgetting to set
LD_LIBRARY_PATHhas caused many issues for DLite users when shared libraries for one version of DLite are used by another version of DLite, possible compiled towards different version of Python.PR #550 automatically patches the virtual environment activate script when installing DLite with CMake to correct set the LD_LIBRARY_PATH when activating the virtual environment.
This issue is about doing the same when installing DLite from pip.
Task: add a post-install action in setup.py (or a new pyproject.toml) that runs patch-activate.sh when the user runs
pip install.The text was updated successfully, but these errors were encountered: