Added sf::Sprite and sf::Texture overload for ImageButton #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! That's something I really needed myself, but wanted to implement later. |
eliasdaler
pushed a commit
that referenced
this pull request
Mar 23, 2017
Update Image(texture, textureRect...)
SebastianMilosz
added a commit
to SebastianMilosz/imgui-sfml
that referenced
this pull request
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe you are interested in my changes:
I have added sfml overloads for ImageButton (does not work otherwise for me).
Some other minor modifications, notable: If using ImGui::Image with only a sf::Sprite the the size of the sprite is taken (e.g. is uses now the scale of the sprite) I think for sprites this is more logical, for sf::Textures everything stays like it is.