Skip to content

fix: DAH-3125 directory page phase 1.5 fix position of where button jumps to #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

josh-chou
Copy link
Collaborator

@josh-chou josh-chou commented May 8, 2025

Description

Change where button links to and update its label

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3125

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2638 May 8, 2025 23:22 Inactive
@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2638 May 8, 2025 23:36 Inactive
@josh-chou josh-chou added the needs review Pull request needs review label May 9, 2025
@josh-chou josh-chou requested review from a team, chadbrokaw and jimlin-sfgov and removed request for a team May 9, 2025 00:54
@josh-chou josh-chou marked this pull request as ready for review May 9, 2025 00:54
@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2638 May 12, 2025 20:05 Inactive
@josh-chou josh-chou merged commit cc14091 into main May 12, 2025
21 checks passed
@josh-chou josh-chou deleted the DAH-3125-Directory-Page-Phase-1.5-Fix-position-of-where-button-jumps-to branch May 12, 2025 20:28
@josh-chou josh-chou added needs product acceptance Pull request requires product acceptance before merging and removed needs review Pull request needs review labels May 12, 2025
@josh-chou josh-chou restored the DAH-3125-Directory-Page-Phase-1.5-Fix-position-of-where-button-jumps-to branch May 12, 2025 20:31
@josh-chou josh-chou deleted the DAH-3125-Directory-Page-Phase-1.5-Fix-position-of-where-button-jumps-to branch May 12, 2025 20:32
josh-chou added a commit that referenced this pull request May 12, 2025
@josh-chou josh-chou restored the DAH-3125-Directory-Page-Phase-1.5-Fix-position-of-where-button-jumps-to branch May 12, 2025 20:51
@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2639 May 12, 2025 21:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product acceptance Pull request requires product acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants