Skip to content

fix: DAH-3106 Clean up analytics events #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chadbrokaw
Copy link
Collaborator

@chadbrokaw chadbrokaw commented May 8, 2025

Description

This PR removes Analytics Events that are no longer being used or have been replaced with newer versions.

Jira ticket

DAH-3106

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@chadbrokaw chadbrokaw changed the title fix: clean up analytics events fix: DAH-3106 Clean up analytics events May 8, 2025
@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2637 May 8, 2025 19:55 Inactive
@chadbrokaw chadbrokaw force-pushed the angular-DAH-3106_analytics_event_cleanup branch from acea130 to b6661f7 Compare May 14, 2025 14:36
@chadbrokaw chadbrokaw temporarily deployed to dahlia-webapp-pr-2637 May 14, 2025 14:37 Inactive
@chadbrokaw chadbrokaw marked this pull request as ready for review May 14, 2025 17:18
@chadbrokaw chadbrokaw requested review from a team, josh-chou and cliu02 and removed request for a team May 14, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants